Remove API that was deprecated during the 5.10 release #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo doesn't have a 6.0 release yet but Swift has. |
patshaughnessy
approved these changes
Sep 24, 2024
| @@ -16,10 +16,6 @@ public protocol DiagnosticConsumer: AnyObject { | |||
| /// - Parameter problems: The encountered diagnostics. | |||
| func receive(_ problems: [Problem]) | |||
|
|
|||
| /// Inform the consumer that the engine has sent all diagnostics for this build. | |||
There was a problem hiding this comment.
Let's also update the copyright message for this file to 2024.
| @@ -105,11 +105,6 @@ public final class DiagnosticEngine { | |||
| } | |||
| } | |||
|
|
|||
| @available(*, deprecated, renamed: "flush()", message: "Use 'flush()' instead. This deprecated API will be removed after 6.0 is released") | |||
There was a problem hiding this comment.
Same as above: update the copyright message to 2024.
| @@ -25,6 +25,3 @@ public struct DocumentationCatalogOption: DirectoryPathOption { | |||
| transform: URL.init(fileURLWithPath:)) | |||
| public var url: URL? | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Same as above: update the copyright message to 2024.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
Now that version 6.0 is released, API that's been deprecated during the 5.10 release can be removed according to the process described in the "Introducing source breaking changes" section of CONTRIBUTING.md.
Dependencies
None.
Testing
Nothing in particular. DocC itself wasn't using this API anymore.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
[ ] Added tests./bin/testscript and it succeeded[ ] Updated documentation if necessary